[MetricBeat] set tags correctly if the dimension value is ARN #19433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
botelastic
bot
added
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
kwinstonix
force-pushed
the
fix-ddos-metrics-tags
branch
from
fabc349 to
aacdd61
Compare
kaiyan-sheng
added
needs_backport
botelastic
bot
removed
the
needs_team
|
jenkins, run the tests please |
kaiyan-sheng
approved these changes
Jul 1, 2020
There was a problem hiding this comment.
Thank you for the contribution!!! @kwinstonix This looks good to me!
|
jenkins, run the tests please |
Merged
6 tasks
kaiyan-sheng
added
v7.9.0
and removed
needs_backport
Merged
6 tasks
kaiyan-sheng
added a commit
that referenced
this pull request
Jul 2, 2020
#19582) * fix setting tags when dimension value is arn format in aws cloudwatch module (cherry picked from commit f96ef57) Co-authored-by: martin <[email protected]>
kaiyan-sheng
added a commit
that referenced
this pull request
Jul 2, 2020
…ension value is ARN (#19583) * [MetricBeat] set tags correctly if the dimension value is ARN (#19433) * fix setting tags when dimension value is arn format in aws cloudwatch module (cherry picked from commit f96ef57) * update changelog Co-authored-by: martin <[email protected]>
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jul 3, 2020
…ne-beats * upstream/master: (35 commits) [ci] fix env variable name for xpack filebeats (elastic#19617) Cache error responses for cloudfoundry apps metadata (elastic#19181) ci: user fixed type of agent (elastic#19625) Input v2 cursor testing (elastic#19573) Update Jenkinsfile to not inspect removed vendor (elastic#19610) Fix ordering and duplicate configs on autodiscover (elastic#19317) Prepare input/file for changes in the registrar (elastic#19516) Cursor input and manager implementation (elastic#19571) [Filebeat] Fix tls mapping in suricata module (elastic#19494) [Ingest Manager] Make Agent beta and Constraints experimental (elastic#19586) Accept prefix as metric_types for stackdriver metricset in GCP (elastic#19345) Implement memlog store operations (elastic#19533) introduce journalbeat/pkg in order to provide reusable shared code (elastic#19581) Add descriptions to HAProxy fields in Metricbeat (elastic#19561) ci: apm-server-update trigered only on upstream, comments, and manual triggered (elastic#19590) ci: enable upstream triggering on the packaging job (elastic#19589) ci: some jjbb improvements (elastic#19588) [MetricBeat] set tags correctly if the dimension value is ARN (elastic#19433) [Filebeat] Add default_fields: false to fields.yml in aws module (elastic#19568) Add publisher implementation for stateful inputs (elastic#19530) ...
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
…c#19433) * fix setting tags when dimension value is arn format in aws cloudwatch module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is to fix setting resource tags when dimension value is ARN format, I found this issue in
AWS/DDoSProtectionnamespace metrics.Why is it important?
cloudwatch module should set event tags correctly if dimension value is ARN format and
tags.resource_type_filterparam is configuredChecklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Screenshots
test with aws shield service and EIP resource , I have put some demo metrics before running test ,so the namespace is
DDoSProtection. The actual value isAWS/DDoSProtectionif you get metrics that created by aws.